test: fix Windows CI execution and resolve exposed platform failures#24476
Merged
test: fix Windows CI execution and resolve exposed platform failures#24476
Conversation
Contributor
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
Contributor
|
Hi @ehedlund, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this. We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines. Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed. Thank you for your understanding and for being a part of our community! |
|
Size Change: -174 B (0%) Total Size: 34 MB
ℹ️ View Unchanged
|
gemini-cli
bot
added
the
status/need-issue
ehedlund
changed the title
18 tasks
…prevent silent skips
scidomino
approved these changes
Apr 3, 2026
bdmorgan
approved these changes
Apr 3, 2026
gemini-cli
bot
removed
the
status/need-issue
Merged
ehedlund
added a commit
that referenced
this pull request
Apr 3, 2026
Adib234
pushed a commit
that referenced
this pull request
Apr 3, 2026
afanty2021
pushed a commit
to afanty2021/gemini-cli
that referenced
this pull request
Apr 4, 2026
warrenzhu25
pushed a commit
to warrenzhu25/gemini-cli
that referenced
this pull request
Apr 9, 2026
HaleTom
pushed a commit
to HaleTom/gemini-cli
that referenced
this pull request
Apr 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR enables core package tests on Windows CI (fixing a PowerShell bug that was silently skipping them) and addresses the cross-platform test failures that were consequently uncovered, ensuring the test suite passes consistently on macOS, Linux, and Windows.
Details
1. CI Workflow Fixes (Windows)
npm run test:ci --workspacearguments in.github/workflows/ci.yml. Without quotes, PowerShell interpreted@(e.g.,@google/gemini-cli-core) as a splatting operator and dropped the argument, causing tests to be silently skipped.if ($LASTEXITCODE -ne 0) { exit $LASTEXITCODE }checks afternpmcommands. PowerShell continues execution by default when an external command fails, meaning subsequent successful steps were previously overwriting the failure code and falsely reporting a green build.2. Cross-Platform Test Fixes
To get the newly unskipped tests passing across all platforms, several types of adjustments were made:
/tmpas a symlink to/private/tmp. Assertions were updated to useresolveToRealPath()so that expected output accurately mirrors runtime path evaluations.fsandvalue-resolver) to behave reliably across OSes without relying on hardcoded, platform-specific path structures.Note: The Windows Sandbox tests have been temporarily disabled in this PR and will be properly addressed and re-enabled in a separate effort (#24480).